Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol-designer): migrate i18n instances to use useTranslation hook #14326

Merged
merged 14 commits into from
Jan 18, 2024

address comments

a5c98c6
Select commit
Loading
Failed to load commit list.
Merged

refactor(protocol-designer): migrate i18n instances to use useTranslation hook #14326

address comments
a5c98c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 18, 2024 in 1s

68.05% (-0.09%) compared to 15ece39

View this Pull Request on Codecov

68.05% (-0.09%) compared to 15ece39

Details

Codecov Report

Attention: 509 lines in your changes are missing coverage. Please review.

Comparison is base (15ece39) 68.13% compared to head (a5c98c6) 68.05%.
Report is 2 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14326      +/-   ##
==========================================
- Coverage   68.13%   68.05%   -0.09%     
==========================================
  Files        2512     2505       -7     
  Lines       71478    71621     +143     
  Branches     9077     9084       +7     
==========================================
+ Hits        48705    48739      +34     
- Misses      20670    20772     +102     
- Partials     2103     2110       +7     
Files Coverage Δ
...omponents/BatchEditForm/makeBatchEditFieldProps.ts 100.00% <100.00%> (ø)
...c/components/LabwareSelectionModal/LabwareItem.tsx 58.33% <100.00%> (+3.78%) ⬆️
...l-designer/src/components/LiquidPlacementModal.tsx 0.00% <ø> (ø)
.../components/StepEditForm/StepEditFormComponent.tsx 0.00% <ø> (ø)
...tepEditForm/fields/PathField/getDisabledPathMap.ts 0.00% <ø> (ø)
...ts/StepEditForm/fields/makeSingleEditFieldProps.ts 90.90% <100.00%> (ø)
...ents/StepEditForm/forms/HeaterShakerForm/index.tsx 88.88% <100.00%> (+1.38%) ⬆️
...rotocol-designer/src/components/alerts/PDAlert.tsx 80.00% <100.00%> (+5.00%) ⬆️
...als/AutoAddPauseUntilHeaterShakerTempStepModal.tsx 100.00% <100.00%> (ø)
...mponents/modals/AutoAddPauseUntilTempStepModal.tsx 100.00% <100.00%> (ø)
... and 120 more

... and 9 files with indirect coverage changes