Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore(app,app-shell,app-shell-odd): update Electron version to v23 #14308

Closed
wants to merge 6 commits into from

Conversation

koji
Copy link
Contributor

@koji koji commented Jan 10, 2024

Overview

Update the Electron version from v21 to v23. Actually, v23 is over the life but ODD has compatibility issues with Chromium v112 and later.
This PR also updates the Nodejs version because of Electron v23's requirement.
https://www.electronjs.org/docs/latest/tutorial/electron-timelines#timeline

RAUT-

Running the application

  • macOS
  • Windows
  • Ubuntu
  • ODD mode
  • ODD

CI

  • update Nodejs version (v16 -> v18)

OT-2

  • USB connection

Other applications

  • Protocol Designer
  • Labware Library
  • Labware Designer

Test Plan

Changelog

Review requests

Risk assessment

Update the Electron version from v21 to v23. Actually v23 is over the life but ODD has compatibility
issues with Chromium v112 and later

RAUT-
@koji
Copy link
Contributor Author

koji commented Jan 10, 2024

fix

  • make check-js errors
  • make lint-js errors
  • make test-js errors

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d377e93) 68.53% compared to head (feb5b55) 68.81%.
Report is 2 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14308      +/-   ##
==========================================
+ Coverage   68.53%   68.81%   +0.28%     
==========================================
  Files        2421     2461      +40     
  Lines       67108    69804    +2696     
  Branches     8823     8823              
==========================================
+ Hits        45993    48037    +2044     
- Misses      19040    19692     +652     
  Partials     2075     2075              
Flag Coverage Δ
components 50.31% <ø> (ø)
g-code-testing 96.48% <ø> (ø)
labware-library 41.10% <ø> (ø)
protocol-designer 34.93% <ø> (ø)
react-api-client 65.73% <ø> (ø)
shared-data 75.12% <ø> (+2.09%) ⬆️
step-generation 86.90% <ø> (ø)
system-server 96.04% <ø> (ø)
update-server 63.58% <ø> (ø)
usb-bridge 76.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 40 files with indirect coverage changes

@koji koji closed this Jan 12, 2024
@koji
Copy link
Contributor Author

koji commented Jan 12, 2024

use V27.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant