-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api): replace single quotes with double quotes #14269
Conversation
Thanks for the consistency cleanup! @ecormany Thoughts on this? In the Python community in general, I don't think there's a strong convention for whether to use single- or double-quotes in API docs. h11 uses double, requests uses single... The Black formatter, which we use, prefers double-quotes, so I'd probably prefer switching everything to that. |
Thanks for opening this PR, Eric! I agree with Max that our standard should be double quotes. We don't 100% adhere to Black (our code blocks use shorter line lengths and we tend to get rid of trailing commas in docs), but the fewer manual changes we have to make to Black-formatted code, the better. That said, the branch name still states the goal: |
@SyntaxColoring @ecormany thanks for considering my PR! Happy to keep this open and ensure the docs have double quotes. I'll tag y'all again once I have an update. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14269 +/- ##
=======================================
Coverage 68.06% 68.06%
=======================================
Files 2508 2508
Lines 71333 71333
Branches 9060 9060
=======================================
Hits 48556 48556
Misses 20674 20674
Partials 2103 2103
Flags with carried forward coverage won't be shown. Click here to find out more. |
@SyntaxColoring @ecormany updates made. I went ahead and changed both v1 and v2 docs for thoroughness. I've updated the main PR body message as well to summarize all the changes. Thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this, Eric. Above and beyond, going back to the v1 docs! (Those are effectively archived, but there's no prohibition against changing them, so we'll accept your edits.)
In reviewing, I tested:
- All modified .py protocol files pass
opentrons_simulate
. - Built v2 documentation locally and visually inspected.
There are a couple remaining improvements that can wait until follow-up PRs. For example, the images on the Tutorial page contain code with single quotes. I don't think there's any possibility for confusion until I get a chance to update those (I have the source files for those images). And the docstrings that compose the API Reference also have some single quotes. I've ticketed both of those internally for a rainy day ☔
@erictleung just so you know, even though these changes are merged, they won't go live until the next time we do a documentation deploy. I expect there will be one sometime this month. |
@ecormany awesome, I appreciate the heads up! Looking forward to it |
This is now deployed as part of the |
Overview
Replaced single quotes with double quotes in tutorial docs, both v1 and v2 docs.
This also changes some example protocols, located in
api/docs/v2/example_protocols/
, which are Python files.And a minor change, this also changes some random non-standard single quotes at the beginning of
api/docs/v2/tutorial.rst
to regular single quotes.Test Plan
N/A
Changelog
Review requests
Risk assessment
Low