refactor(app): remove excessive axis homing in drop tip wizard #14239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that moveToAddressableArea provides the ability to home to Z axis before moving, let's remove the homing done during the flows but keep still keep the homing behavior at the end of the flow.
mjhuff
changed the title
mjhuff
changed the title
mjhuff
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14239 +/- ##
=======================================================
+ Coverage 70.39% 70.40% +0.01%
=======================================================
Files 2513 2513
Lines 71343 71322 -21
Branches 9037 9033 -4
=======================================================
- Hits 50219 50217 -2
+ Misses 18918 18899 -19
Partials 2206 2206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mjhuff
force-pushed
the
app_remove-excessive-homing-drop-tip
branch
from
80e0c59 to
fd1d846
Compare
ncdiehl11
pushed a commit
that referenced
this pull request
Dec 20, 2023
* refactor(app): remove excessive axis homing Now that moveToAddressableArea provides the ability to home to Z axis before moving, let's remove the homing done during the flows but keep still keep the homing behavior at the end of the flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Now that moveToAddressableArea provides the ability to home to Z axis before moving, let's remove the homing done during the flows but keep still keep the homing behavior at the end of the flow.
Test Plan
Changelog
Risk assessment
low