feat(app): add loading state to ODD protocol list #14238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokamin
requested review from
TamarZanzouri,
sfoster1 and
b-cooper
and removed request for
a team
shlokamin
commented
Dec 18, 2023
| name="ot-spinner" | ||
| spin | ||
| size={SIZE_2} | ||
| marginY={'-1.5rem'} |
There was a problem hiding this comment.
used a negative margin here to get around the spinner icon taking up padding room. if someone knows a better way to do that lmk
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14238 +/- ##
=======================================================
- Coverage 70.41% 70.38% -0.04%
=======================================================
Files 1636 2513 +877
Lines 54490 71461 +16971
Branches 4034 9101 +5067
=======================================================
+ Hits 38371 50298 +11927
- Misses 15420 18944 +3524
- Partials 699 2219 +1520
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a loading state to the protocols list page when there is a pending analysis. This fixes a bug where we were eagerly showing an error state before a protocol finished analyzing.
closes RQA-2137
Risk assessment
Low