Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): add new text to updatebanner for module card #14237

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 18, 2023

Overview

The design team added new text for the case required pipette calibration and module calibration.

[design]
https://www.figma.com/file/Nx7ORMnfyJNP4FQYxN4e5x/Primary%3A-Desktop-App?type=design&node-id=1766%3A165682&mode=design&t=opTVF3AR964bRuGd-1

require to attach a pipette
Screenshot 2023-12-18 at 3 03 22 PM

require calibrating a pipette
Screenshot 2023-12-18 at 3 34 45 PM

close RQA-2133

Test Plan

[require calibrating]

  1. remove pipette calibration data and module calibration data
  2. go to Device details page on Desktop app
    Check the banner says required calibrating before running module calibration.

[require attaching]

  1. detach all pipettes
  2. go to Device details page on Desktop app
    Check the banner says require attaching pipette before running module calibration.

Changelog

  • add calibratePipetteRequired to check calibrated or not and update attachPipetteRequired

Review requests

Risk assessment

The design team added new text for the case required pipette calibration and module calibration

close RQA-2133
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #14237 (2c8ae07) into chore_release-7.1.0 (d2e9f57) will increase coverage by 0.00%.
Report is 3 commits behind head on chore_release-7.1.0.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.1.0   #14237   +/-   ##
====================================================
  Coverage                70.38%   70.39%           
====================================================
  Files                     2513     2513           
  Lines                    71332    71338    +6     
  Branches                  9030     9035    +5     
====================================================
+ Hits                     50210    50215    +5     
  Misses                   18917    18917           
- Partials                  2205     2206    +1     
Flag Coverage Δ
app 67.50% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/molecules/UpdateBanner/index.tsx 100.00% <100.00%> (ø)
...pp/src/organisms/Devices/InstrumentsAndModules.tsx 64.81% <100.00%> (+0.66%) ⬆️
.../Devices/ProtocolRun/ProtocolRunModuleControls.tsx 77.77% <100.00%> (+0.85%) ⬆️
app/src/organisms/ModuleCard/index.tsx 59.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@koji koji requested review from mjhuff and a team December 18, 2023 20:37
@koji koji marked this pull request as ready for review December 18, 2023 20:40
@koji koji requested a review from a team as a code owner December 18, 2023 20:40
@koji koji removed the request for review from a team December 18, 2023 20:43
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for fixing!

@koji koji merged commit 24310ce into chore_release-7.1.0 Dec 18, 2023
22 checks passed
ncdiehl11 pushed a commit that referenced this pull request Dec 20, 2023
* fix(app): add new text to updatebanner for module card
@koji koji deleted the fix_add-new-text-to-module-card-banner branch April 17, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants