fix(app): Don't render ProtocolRunHeader TerminalBanner on CurrentRun #14233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error modal render should not be tied to CurrentRun but rather if the mostRecentRun is the currently viewed run.
mjhuff
commented
Dec 18, 2023
| @@ -1054,26 +1054,4 @@ describe('ProtocolRunHeader', () => { | |||
| expect(queryByText('Tips may be attached.')).not.toBeInTheDocument() | |||
| }) | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
This test is functionally a duplicate of the one above now that we don't tie the drop tip banners to currentRunId, therefore I removed it.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14233 +/- ##
=======================================================
+ Coverage 70.38% 70.41% +0.02%
=======================================================
Files 2513 1636 -877
Lines 71332 54490 -16842
Branches 9030 4034 -4996
=======================================================
- Hits 50210 38369 -11841
+ Misses 18917 15421 -3496
+ Partials 2205 700 -1505
Flags with carried forward coverage won't be shown. Click here to find out more. |
koji
reviewed
Dec 18, 2023
| @@ -1,8 +1,9 @@ | |||
| import { useAllRunsQuery } from '@opentrons/react-api-client' | |||
| import { last } from 'lodash' | |||
There was a problem hiding this comment.
Basically we import a specific one instead of importing the entire lodash
Suggested change
| import { last } from 'lodash' | |
| import last from 'lodash/last' |
koji
reviewed
Dec 18, 2023
| return allRuns != null && allRuns.data.length > 0 | ||
| ? allRuns.data[allRuns.data.length - 1].id | ||
| return allRuns != null && allRuns.data?.length > 0 | ||
| ? last(allRuns.data)?.id ?? null |
koji
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-2013
Overview
This PR fixes an issue where opening the error banner would de-render the error banner. Instead of conditionally rendering the error banner on whether a run is current, let's follow the new pattern we use for the drop tip banner: render it if the mostRecentRunId is the currently viewed run.
Addresses the same issue for clicking on "remove tips" within the drop tip banner - the wizard would never properly start after viewing the error message (since it clears the run).
PR includes some refactoring for the getMostRecentRunId hook to make it a bit safer.
Current Behavior
2023-12-06_15-59-22.1.mp4
Fixed Behavior
Screen.Recording.2023-12-18.at.1.55.58.PM.mov
Test Plan
Changelog
Risk assessment
low