Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add gradient scrim to ODD protocol command list #14232

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Dec 18, 2023

closes RQA-1630

Overview

To indicate that the RunningProtocolCommandList on ODD is not scrollable, designs specify a gradient scrim at the bottom of the list. Here, I add a sibling component that occupies that same space as the command list and provides this gradient scrim.

Test Plan

on physical ODD:

  • verify that scrim is present at the bottom of the command list and does not affect functionality of buttons.
Screen Shot 2023-12-18 at 12 13 09 PM

Changelog

  • add placeholder Flex to provide scrim at bottom of running protocol command list

Risk assessment

low

To indicate that the RunningProtocolCommandList on ODD is not scrollable, designs specify a gradient
scrim at the bottom of the list. Here, I add a sibling component that occupies that same space as
the command list and provides this gradient scrim.
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner December 18, 2023 18:49
@ncdiehl11 ncdiehl11 requested review from smb2268 and removed request for a team December 18, 2023 18:49
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #14232 (c0cfc06) into chore_release-7.1.0 (5fc0e29) will decrease coverage by 0.01%.
Report is 5 commits behind head on chore_release-7.1.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14232      +/-   ##
=======================================================
- Coverage                70.38%   70.38%   -0.01%     
=======================================================
  Files                     2513     2513              
  Lines                    71333    71335       +2     
  Branches                  9030     9032       +2     
=======================================================
+ Hits                     50211    50212       +1     
  Misses                   18917    18917              
- Partials                  2205     2206       +1     
Flag Coverage Δ
app 67.49% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/pages/OnDeviceDisplay/RunningProtocol.tsx 58.92% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇
Mel will be happy for this!

Co-authored-by: koji <[email protected]>
@ncdiehl11 ncdiehl11 merged commit 6417cf7 into chore_release-7.1.0 Dec 18, 2023
22 checks passed
@ncdiehl11 ncdiehl11 deleted the odd_add-gradient-to-runlog branch December 18, 2023 21:50
ncdiehl11 added a commit that referenced this pull request Dec 20, 2023
* feat(app): add gradient scrim to ODD protocol command list

closes RQA-1630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants