Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix persistent cancelled state #14228

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Dec 15, 2023

Closes RQA-2123 and RQA-2122

Overview

We actually do want to close the current run as we were before, as this logic is used elsewhere in the app. This PR adds back this logic and only shows the drop tip banner if the most recent run is equal to the runId passed into the run details page.

Test Plan

  • Test drop tip flows work.
  • Cancelling a run should allow you to perform actions from the devices page overflow menu such as homing the gantry or restarting the robot (these are no longer disabled).

Risk assessment

low

@mjhuff mjhuff requested review from sfoster1 and b-cooper December 15, 2023 22:52
@mjhuff mjhuff requested a review from a team as a code owner December 15, 2023 22:52
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #14228 (292ed77) into chore_release-7.1.0 (8c82d7c) will increase coverage by 0.03%.
Report is 3 commits behind head on chore_release-7.1.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14228      +/-   ##
=======================================================
+ Coverage                70.39%   70.42%   +0.03%     
=======================================================
  Files                     2513     1636     -877     
  Lines                    71328    54495   -16833     
  Branches                  9029     4034    -4995     
=======================================================
- Hits                     50208    38376   -11832     
+ Misses                   18915    15420    -3495     
+ Partials                  2205      699    -1506     
Flag Coverage Δ
app 38.89% <ø> (-28.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 877 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sfoster1 sfoster1 merged commit 2d0bcfd into chore_release-7.1.0 Dec 15, 2023
20 checks passed
@sfoster1 sfoster1 deleted the app_fix-persistent-cancelled-state branch December 15, 2023 22:59
ncdiehl11 pushed a commit that referenced this pull request Dec 19, 2023
* fix(app): add dimsissing current run back

* fix(app): fix robot stuck in cancelled state

* test fixes
ncdiehl11 pushed a commit that referenced this pull request Dec 20, 2023
* fix(app): add dimsissing current run back

* fix(app): fix robot stuck in cancelled state

* test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants