Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shared-data): revert PCR plate grip force back to 15N #14221

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

ahiuchingau
Copy link
Contributor

Overview

We're that some grippers are not able to pick up the Armadillo PCR properly after the change in QA, so we're changing it back to 15 N.

Test Plan

Changelog

Review requests

Risk assessment

@ahiuchingau ahiuchingau requested a review from a team as a code owner December 15, 2023 18:57
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #14221 (7625832) into chore_release-7.1.0 (9842207) will not change coverage.
Report is 2 commits behind head on chore_release-7.1.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.1.0   #14221   +/-   ##
====================================================
  Coverage                70.39%   70.39%           
====================================================
  Files                     2513     2513           
  Lines                    71323    71323           
  Branches                  9025     9025           
====================================================
  Hits                     50209    50209           
  Misses                   18908    18908           
  Partials                  2206     2206           
Flag Coverage Δ
app 67.50% <ø> (ø)
labware-library 51.50% <ø> (ø)
protocol-designer 45.01% <ø> (ø)
shared-data 75.04% <ø> (ø)
step-generation 86.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool!

@ahiuchingau ahiuchingau merged commit d2e9f57 into chore_release-7.1.0 Dec 18, 2023
64 checks passed
@ahiuchingau ahiuchingau deleted the revert_grip-force-back-to-15N branch December 18, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants