Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): support addressable areas in manual intervention modal locations #14220

Merged

Conversation

b-cooper
Copy link
Contributor

Overview

Fix bug in which moves to manual moves to addressable areas would show nothing in the manual intervention modal

Closes RQA-2114, Closes RQA-2115

Risk assessment

low

…tions

Fix bug in which moves to manual moves to addressable areas would show nothing in the manual
intervention modal

Closes RQA-2114, Closes RQA-2115
@b-cooper b-cooper requested a review from a team as a code owner December 15, 2023 18:55
@b-cooper b-cooper requested review from ncdiehl11, koji and brenthagen and removed request for a team December 15, 2023 18:55
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change makes sense to me ✔️

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #14220 (2b7429e) into chore_release-7.1.0 (9842207) will decrease coverage by 0.01%.
Report is 1 commits behind head on chore_release-7.1.0.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14220      +/-   ##
=======================================================
- Coverage                70.39%   70.39%   -0.01%     
=======================================================
  Files                     2513     2513              
  Lines                    71323    71329       +6     
  Branches                  9025     9028       +3     
=======================================================
+ Hits                     50209    50211       +2     
- Misses                   18908    18912       +4     
  Partials                  2206     2206              
Flag Coverage Δ
app 67.49% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sms/CommandText/utils/getLabwareDisplayLocation.ts 14.28% <0.00%> (-0.72%) ⬇️
...terventionModal/MoveLabwareInterventionContent.tsx 41.53% <50.00%> (+0.55%) ⬆️

@b-cooper b-cooper merged commit 5d4845f into chore_release-7.1.0 Dec 15, 2023
21 of 22 checks passed
@b-cooper b-cooper deleted the app_fix-manual-intervention-modal-aa-location branch December 15, 2023 19:10
ncdiehl11 pushed a commit that referenced this pull request Dec 20, 2023
…tions (#14220)

Fix bug in which moves to manual moves to addressable areas would show nothing in the manual
intervention modal

Closes RQA-2114, Closes RQA-2115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants