Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): e-stop modal button state issue #14217

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 15, 2023

Overview

The issue was caused by unexpected state change via useEffect.
Remove useEffect and update handleClick.
close RQA-2111

Test Plan

  1. press e-stop button
  2. twist e-stop button
  3. click resume button
    the button shows spinner and not back to normal state and for ODD, the modal is gone.
    There will be some delay since fetching duration is 10sec.

Changelog

Review requests

Risk assessment

low

koji added 2 commits December 15, 2023 13:15
remove useEffect to avoid unexpected state change

close RQA-2111
@koji koji requested review from mjhuff and a team December 15, 2023 18:22
@koji koji marked this pull request as ready for review December 15, 2023 18:22
@koji koji requested a review from a team as a code owner December 15, 2023 18:22
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #14217 (3805318) into chore_release-7.1.0 (a7d1187) will decrease coverage by 0.10%.
Report is 5 commits behind head on chore_release-7.1.0.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14217      +/-   ##
=======================================================
- Coverage                70.42%   70.32%   -0.10%     
=======================================================
  Files                     2512     2513       +1     
  Lines                    71296    71574     +278     
  Branches                  9006     9137     +131     
=======================================================
+ Hits                     50212    50337     +125     
- Misses                   18879    19015     +136     
- Partials                  2205     2222      +17     
Flag Coverage Δ
app 67.26% <33.33%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/organisms/EmergencyStop/EstopPressedModal.tsx 66.66% <33.33%> (-0.84%) ⬇️

... and 5 files with indirect coverage changes

@koji koji removed the request for review from a team December 15, 2023 18:23
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thank you for fixing this!

@koji koji merged commit ef937ee into chore_release-7.1.0 Dec 15, 2023
27 of 28 checks passed
ncdiehl11 pushed a commit that referenced this pull request Dec 20, 2023
* fix(app): fix estop modal button state issue
@koji koji deleted the fix_estop-modal-button-issues branch April 17, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants