fix(api): allow volume 0 commands in engine #14211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14211 +/- ##
=======================================================
- Coverage 70.42% 70.35% -0.07%
=======================================================
Files 2512 1636 -876
Lines 71296 54547 -16749
Branches 9006 4050 -4956
=======================================================
- Hits 50212 38379 -11833
+ Misses 18879 15469 -3410
+ Partials 2205 699 -1506
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
changed the title
SyntaxColoring
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Tested with this protocol. Works as expected. Thank you!
requirements = {"apiLevel": "2.16", "robotType": "Flex"}
def run(protocol):
tip_rack = protocol.load_labware("opentrons_flex_96_tiprack_1000ul", "D1")
well_plate_1 = protocol.load_labware(
"opentrons_96_wellplate_200ul_pcr_full_skirt", "D2"
)
well_plate_2 = protocol.load_labware(
"opentrons_96_wellplate_200ul_pcr_full_skirt", "C2"
)
pipette = protocol.load_instrument(
"flex_1channel_1000", "left", tip_racks=[tip_rack]
)
pipette.pick_up_tip()
protocol.comment(str(well_plate_1.wells()))
for source, dest in zip(well_plate_1.wells(), well_plate_2.wells()):
pipette.aspirate(0, source)
pipette.dispense(0, dest)
pipette.return_tip()
ncdiehl11
pushed a commit
that referenced
this pull request
Dec 20, 2023
A previous PR (12a630b / #13989 ) changed the python protocol api in version 2.16 to allow commanding 0ul liquid handling commands like aspirate, mix, and dispense. This is useful in programmatic protocols that read out volumes to handle; they can now handle 0 volume properly. In 2.15 and previous, specifying 0 would lead to those commands doing the most volume they could (i.e. aspirate the full tip volume, dispense whatever's currently in the pipette, mix at full volume) and this likely was an unintentional side effect because of python truthiness. However, that change only touched the python protocol API; that API would emit commands to the engine that specified 0 volume, and those were not allowed: the pydantic models for the commands and responses required strictly greater than 0 volume. This PR - changes the pydantic models and updates the schema to allow 0ul commands - adds a python protocol to be an integration test - adds unit tests for the python protocol api aspirate and dispense commands --------- Co-authored-by: Seth Foster <[email protected]> Co-authored-by: Max Marrone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR (12a630b / #13989 ) changed the python protocol api in version 2.16 to allow commanding 0ul liquid handling commands like aspirate, mix, and dispense. This is useful in programmatic protocols that read out volumes to handle; they can now handle 0 volume properly. In 2.15 and previous, specifying 0 would lead to those commands doing the most volume they could (i.e. aspirate the full tip volume, dispense whatever's currently in the pipette, mix at full volume) and this likely was an unintentional side effect because of python truthiness.
However, that change only touched the python protocol API; that API would emit commands to the engine that specified 0 volume, and those were not allowed: the pydantic models for the commands and responses required strictly greater than 0 volume.
This PR