Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): correct aspect ratio of waste chute image #14204

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ecormany
Copy link
Contributor

Overview

Waste chute was looking a little bit wiiiiiiiide

Screenshot 2023-12-14 at 2 33 23 PM

Test Plan

Not so wide running this branch locally.

Screenshot 2023-12-14 at 2 33 07 PM

Changelog

  • padded pixel dimensions of image to exact 3x2 ratio
  • crushed file with ImageOptim

Review requests

looks good?

Risk assessment

v v low, just the image asset.

@ecormany ecormany requested review from jerader and a team December 14, 2023 19:38
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #14204 (aba37e7) into edge (ef15185) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14204   +/-   ##
=======================================
  Coverage   70.38%   70.38%           
=======================================
  Files        2510     2510           
  Lines       71292    71292           
  Branches     9019     9019           
=======================================
  Hits        50179    50179           
  Misses      18901    18901           
  Partials     2212     2212           
Flag Coverage Δ
protocol-designer 44.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 👨‍🎨 beautiful! thanks for fixing this!

@ecormany ecormany merged commit 5883939 into edge Dec 14, 2023
20 checks passed
@ecormany ecormany deleted the pd-fix-wide-chute branch December 14, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants