Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): allow ODD to poll for completed analysis on protocol setup #14197

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

b-cooper
Copy link
Contributor

Overview

Prevent bug where odd will not proceed past protocol setup screen because of lack of completed analysis

RQA-2074

Risk assessment

low

Prevent bug where odd will not proceed past protocol setup screen because of lack of completed
analysis

RQA-2074
@b-cooper b-cooper requested a review from a team as a code owner December 13, 2023 23:12
@b-cooper b-cooper requested review from smb2268 and removed request for a team December 13, 2023 23:12
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #14197 (102282e) into chore_release-7.1.0 (bfd1420) will decrease coverage by 0.12%.
Report is 34 commits behind head on chore_release-7.1.0.
The diff coverage is 94.44%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14197      +/-   ##
=======================================================
- Coverage                70.44%   70.32%   -0.12%     
=======================================================
  Files                     2512     2512              
  Lines                    71223    72073     +850     
  Branches                  8971     9353     +382     
=======================================================
+ Hits                     50172    50688     +516     
- Misses                   18857    19117     +260     
- Partials                  2194     2268      +74     
Flag Coverage Δ
app 67.26% <94.44%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/pages/OnDeviceDisplay/ProtocolSetup/index.tsx 76.03% <94.44%> (+4.05%) ⬆️

... and 29 files with indirect coverage changes

@b-cooper b-cooper merged commit c08937e into chore_release-7.1.0 Dec 14, 2023
22 checks passed
@b-cooper b-cooper deleted the app_fix-odd-analysis-refetch branch December 14, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants