Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): update error messaging for module calibration #14195

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Dec 13, 2023

fix RQA-2084

Overview

Update error messaging for module calibration error. This should show the new error messaging and then on the next line, show the message from the server

Test Plan

Changelog

Review requests

Risk assessment

Low

@smb2268 smb2268 requested a review from a team as a code owner December 13, 2023 22:11
@smb2268 smb2268 requested review from koji, shlokamin, jerader, b-cooper and mjhuff and removed request for a team and koji December 13, 2023 22:11
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #14195 (442ded4) into chore_release-7.1.0 (76bf6b8) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14195      +/-   ##
=======================================================
+ Coverage                70.42%   70.43%   +0.01%     
=======================================================
  Files                     1636     2512     +876     
  Lines                    54504    71272   +16768     
  Branches                  4028     8999    +4971     
=======================================================
+ Hits                     38384    50203   +11819     
- Misses                   15420    18860    +3440     
- Partials                   700     2209    +1509     
Flag Coverage Δ
app 67.64% <ø> (+28.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/organisms/ModuleWizardFlows/index.tsx 2.15% <ø> (ø)

... and 875 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a robot, works as advertised!

@sfoster1 sfoster1 merged commit f440726 into chore_release-7.1.0 Dec 13, 2023
22 checks passed
@sfoster1 sfoster1 deleted the app_module-cal-error branch December 13, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants