Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): use adapter labwareId when checking adapter quirk #14191

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Dec 13, 2023

Overview

Fixes a bug where the deck conflict checker was looking for tiprackAdapterFor96Channel quirk on the tiprack instead of on the adapter

Test Plan

requirements = {
	"robotType": "Flex",
	"apiLevel": "2.16"
}

def run(protocol_context):
	trash_labware = protocol_context.load_labware("opentrons_1_trash_3200ml_fixed", "A3")

	tip_rack1 = protocol_context.load_labware("opentrons_flex_96_tiprack_50ul", "C3")
	tip_rack2 = protocol_context.load_labware("opentrons_flex_96_tiprack_200ul", "B3", adapter="opentrons_flex_96_tiprack_adapter")

	instrument = protocol_context.load_instrument('flex_96channel_1000', mount="left", tip_racks=[tip_rack1, tip_rack2])
	instrument.trash_container = trash_labware

	# Should not error out
	instrument.pick_up_tip(tip_rack2.wells()[0])
	instrument.drop_tip()

	# Should raise error because tiprack1 is not on adapter
	instrument.pick_up_tip()
	instrument.drop_tip()

Changelog

  • use the correct labware id in deck conflict and test

Risk assessment

None. Bug fix

@sanni-t sanni-t requested a review from a team as a code owner December 13, 2023 18:52
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #14191 (17a1b9e) into chore_release-7.1.0 (b1d774d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.1.0   #14191   +/-   ##
====================================================
  Coverage                70.46%   70.46%           
====================================================
  Files                     2512     2512           
  Lines                    71233    71233           
  Branches                  8982     8982           
====================================================
  Hits                     50191    50191           
  Misses                   18843    18843           
  Partials                  2199     2199           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed on protocol with loaded 96ch adapter, passes analysis and runs on Flex allowing pickup tip.

@sanni-t sanni-t merged commit 4c76d5f into chore_release-7.1.0 Dec 13, 2023
31 checks passed
@sanni-t sanni-t deleted the fix_tiprack_parent_quirk_checker branch December 13, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants