-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Allow omitting the mount when loading a 96-channel #14187
feat(api): Allow omitting the mount when loading a 96-channel #14187
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14187 +/- ##
=======================================================
- Coverage 70.45% 70.45% -0.01%
=======================================================
Files 2512 2512
Lines 71237 71232 -5
Branches 8982 8982
=======================================================
- Hits 50189 50184 -5
Misses 18849 18849
Partials 2199 2199
Flags with carried forward coverage won't be shown. Click here to find out more.
|
:param str instrument_name: The name of the instrument model, or a | ||
prefix. For instance, 'p10_single' may be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure when this prefix thing was true, but it is not true now and it's weird, so I'm removing it from the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From docs side, go ahead with this. The docstrings will carry along no problem. I'm doing a huge refactor of the Pipettes page (#14189), to the point it's not compatible with rebasing, so I'll incorporate those changes by copy-paste into that branch.
:param str instrument_name: The name of the instrument model, or a | ||
prefix. For instance, 'p10_single' may be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚮
Co-authored-by: Ed Cormany <[email protected]>
Co-authored-by: Ed Cormany <[email protected]>
Overview
The 96-Channel Pipette physically occupies both mounts. But a quirk (not ticketed) of our current Python Protocol API is that you need to specify
mount="left"
ormount="right"
. This PR fixes that quirk.Changelog
Before this PR:
load_instrument()
method takes amount
argument that's required to be"left"
or"right"
."left"
if you're loading a 96-Channel."left"
and"right"
do the same thing in practice.With this PR:
mount
argument is allowed to be omitted orNone
if you're loading a 96-channel. For all other pipettes, it's still required to be"left"
or"right"
.mount
if you're loading a 96-channel.This is roughly analogous to how we treat the Thermocycler Module, which can only be loaded into one location.
Test Plan
Review requests
Is this a good idea to do now, or were we deliberately making people do
mount="<something>"
?Risk assessment
Low.