refactor(protocol-designer, step-generation): allow aluminum blocks t… #14174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be moved, disallow adapters closes RQA-2060
jerader
requested review from
koji and
mjhuff
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14174 +/- ##
=======================================
Coverage 70.40% 70.40%
=======================================
Files 2510 2510
Lines 71201 71202 +1
Branches 8971 8970 -1
=======================================
+ Hits 50127 50128 +1
Misses 18880 18880
Partials 2194 2194
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
reviewed
Dec 12, 2023
| const { dimensions, parameters } = labwareDef | ||
| const { xDimension, yDimension } = dimensions | ||
|
|
||
| const smallXDimension = xDimension < 127.75 |
There was a problem hiding this comment.
nit
maybe isSmallerXDimension since it would be easy to understand that the const is boolean.
There was a problem hiding this comment.
oh ya good call! thanks!
koji
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o be moved, disallow adapters
closes RQA-2060
Overview
The off-deck slideout now filters out adapters but keeps aluminum blocks. And aluminum blocks can not be moved only manually.
Test Plan
Create either a Flex or Ot-2 protocol. Add a gripper. On the design tab, click on the edit off-deck button and in the labware selection, the adapters should NOT be available. The aluminum blocks SHOULD be available. Click to add an aluminum block off-deck.
Create a move labware step and move the aluminum block off-deck and onto a slot. The step should be created correctly.
Create a new move labware step and move the aluminum block to a new slot (not off-deck) and make sure the
use grippercheckbox is selected. This step should error and show a timeline error saying that the gripper cannot move aluminum blocks. If you edit the step and uncheck the the box, the step should work as expected.Changelog
LabwareSelectionModal's util logic and filter out adapters if the slot is off-deckCANNOT_MOVE_WITH_GRIPPERand add to i18nmoveLabwareatomic commandReview requests
see test plan
Risk assessment
low