Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix module calibration selection slot issue #14168

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 11, 2023

Overview

I'm going to go with an easy way.

close RQA-2049

Test Plan

run module calibration h/s module and temperature module

Changelog

  • add A3 to h/s module and temperature module

Review requests

Risk assessment

low

I'm going to go with an easy way

close RQA-20
@koji koji requested a review from a team December 11, 2023 22:17
@koji koji marked this pull request as ready for review December 11, 2023 22:18
@koji koji requested a review from a team as a code owner December 11, 2023 22:18
@koji koji requested review from shlokamin and removed request for a team and shlokamin December 11, 2023 22:19
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #14168 (0b1adcb) into chore_release-7.1.0 (f7caea6) will increase coverage by 0.01%.
Report is 3 commits behind head on chore_release-7.1.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14168      +/-   ##
=======================================================
+ Coverage                70.45%   70.47%   +0.01%     
=======================================================
  Files                     2512     2512              
  Lines                    71217    71220       +3     
  Branches                  8971     8974       +3     
=======================================================
+ Hits                     50177    50192      +15     
+ Misses                   18844    18832      -12     
  Partials                  2196     2196              
Flag Coverage Δ
app 67.72% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/organisms/ModuleWizardFlows/constants.ts 100.00% <ø> (ø)

... and 11 files with indirect coverage changes

Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this out and it worked as expected!

@koji koji merged commit 3a93fc4 into chore_release-7.1.0 Dec 11, 2023
24 of 28 checks passed
@koji koji deleted the fix_module-calibration-selection branch December 11, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants