Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): disable robot overflow menu when robot has an existing maintenance run #14162

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

shlokamin
Copy link
Member

Overview

This PR updates the useisRobotBusy hook to check for the existence of a current maintenance run. This will affect:

  • The robot overflow menu (whether or not we allow users to create a run)
  • Advanced settings on the desktop app (whether to enable/disable toggles)
  • Advanced settings on the ODD (whether to enable/disable toggles)
  • The desktop app’s update modal (whether or not we allow users to initiate an update)

Closes RQA-1170

Risk assessment

low

@shlokamin shlokamin requested a review from a team as a code owner December 11, 2023 19:29
@shlokamin shlokamin requested review from brenthagen and removed request for a team December 11, 2023 19:29
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #14162 (a225b9b) into chore_release-7.1.0 (f7caea6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.1.0   #14162   +/-   ##
====================================================
  Coverage                70.45%   70.46%           
====================================================
  Files                     2512     2512           
  Lines                    71217    71219    +2     
  Branches                  8971     8971           
====================================================
+ Hits                     50177    50182    +5     
+ Misses                   18844    18843    -1     
+ Partials                  2196     2194    -2     
Flag Coverage Δ
app 67.67% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/organisms/Devices/hooks/useIsRobotBusy.ts 92.85% <100.00%> (+1.19%) ⬆️

... and 2 files with indirect coverage changes

@shlokamin shlokamin requested review from koji, b-cooper and smb2268 and removed request for brenthagen December 11, 2023 19:29
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@shlokamin shlokamin merged commit 6f14276 into chore_release-7.1.0 Dec 11, 2023
30 checks passed
@shlokamin shlokamin deleted the app_update-robot-busy-logic branch December 11, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants