fix(app): moveLabware command text support for waste chute #14153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14153 +/- ##
=======================================================
- Coverage 70.44% 70.42% -0.02%
=======================================================
Files 2512 1636 -876
Lines 71224 54507 -16717
Branches 8972 4024 -4948
=======================================================
- Hits 50173 38388 -11785
+ Misses 18857 15423 -3434
+ Partials 2194 696 -1498
Flags with carried forward coverage won't be shown. Click here to find out more. |
koji
reviewed
Dec 8, 2023
Comment on lines
2
to
7
| import { | ||
| CompletedProtocolAnalysis, | ||
| MoveLabwareRunTimeCommand, | ||
| RobotType, | ||
| } from '@opentrons/shared-data/' | ||
| GRIPPER_WASTE_CHUTE_ADDRESSABLE_AREA, | ||
| } from '@opentrons/shared-data' |
There was a problem hiding this comment.
I think these are types so probably getting back type and moving them down would be better.
Then import GRIPPER_WASTE_CHUTE_ADDRESSABLE_AREA separately.
koji
reviewed
Dec 8, 2023
| } from '@opentrons/shared-data' | ||
| import { i18n } from '../../../i18n' | ||
| import { CommandText } from '../' | ||
| import { mockRobotSideAnalysis } from '../__fixtures__' | ||
|
|
||
| import type { | ||
| AspirateInPlaceRunTimeCommand, |
koji
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-2037
Overview
Add waste chute support in run log for moving labware into the waste chute
Test Plan
Test with the protocol attached to the ticket! Look at the run log and see that the command text for moving labware into waste chute is correct
Changelog
moveLabwareCommandTextand add test coverageReview requests
see test plan
Risk assessment
low