Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-client): update initial loaded labware to support addressable areas #14150

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Dec 8, 2023

Closes RQA-2005

Overview

Labware loaded into staging areas are not included into the total labware count. parseInitialLoadedLabwareBySlot utility now includes addressableAreaName in its reduce criteria.

Current Behavior

Screenshot 2023-12-06 at 2 18 01 PM

Fixed Behavior

Screenshot 2023-12-08 at 11 00 11 AM

Test Plan

Changelog

  • The loaded labware total count correctly reflects all loaded labware.

Risk assessment

low

@mjhuff mjhuff requested review from brenthagen and a team December 8, 2023 16:09
@mjhuff mjhuff requested a review from a team as a code owner December 8, 2023 16:09
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #14150 (fc77770) into chore_release-7.1.0 (d7646ac) will not change coverage.
Report is 41 commits behind head on chore_release-7.1.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.1.0   #14150   +/-   ##
====================================================
  Coverage                70.46%   70.46%           
====================================================
  Files                     2512     2512           
  Lines                    71196    71196           
  Branches                  8958     8958           
====================================================
  Hits                     50168    50168           
  Misses                   18837    18837           
  Partials                  2191     2191           
Flag Coverage Δ
react-api-client 65.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🛻

@mjhuff mjhuff merged commit faf7b51 into chore_release-7.1.0 Dec 8, 2023
16 checks passed
@mjhuff mjhuff deleted the api-client_include-addressable-area-in-loaded-labware branch December 8, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants