changes so far found in v7.1.0-alpha.2 vs v7.0.2 #14148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@y3rsh it may be tough to do in this pr obviously but since git diff tools work on lines, can we format this json with like one key/value pair per line? |
y3rsh
force-pushed
the
7.1-analyses-battery-diff
branch
from
eccd81a to
5539465
Compare
y3rsh
commented
Dec 8, 2023
| @@ -2671,7 +2671,7 @@ | |||
| ], | |||
| "metadata": { | |||
| "displayCategory": "tipRack", | |||
| "displayName": "Opentrons 96 Tip Rack 20 µL", | |||
| "displayName": "Opentrons OT-2 96 Tip Rack 20 µL", | |||
There was a problem hiding this comment.
Expected change due to change in shared-data
shared-data/labware/definitions/2/opentrons_96_tiprack_300ul/1.json
y3rsh
commented
Dec 8, 2023
| @@ -50,7 +50,7 @@ | |||
| "dropOffset": { | |||
| "x": 0.0, | |||
| "y": 0.0, | |||
| "z": 0.5 | |||
| "z": 1.0 | |||
There was a problem hiding this comment.
@sanni-t please take a look at this and all the other changes to values in this PR when you can 😊
y3rsh
commented
Dec 8, 2023
| @@ -6881,7 +6881,7 @@ | |||
| "errorInfo": { | |||
| "args": "('Cannot aspirate more than pipette max volume',)", | |||
| "class": "AssertionError", | |||
| "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/commands/publisher.py\", line 113, in publish_context\n yield\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/instrument_context.py\", line 238, in aspirate\n self._core.aspirate(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/legacy_simulator/legacy_instrument_core.py\", line 112, in aspirate\n new_volume <= self._pipette_dict[\"working_volume\"]\n" | |||
| "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/commands/publisher.py\", line 113, in publish_context\n yield\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/instrument_context.py\", line 267, in aspirate\n self._core.aspirate(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/legacy_simulator/legacy_instrument_core.py\", line 119, in aspirate\n new_volume <= self._pipette_dict[\"working_volume\"]\n" | |||
There was a problem hiding this comment.
Think I will ignore traceback key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use snapshots to compare protocol analysis across builds
Bugs found
Signoff