Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): Delete unused hard-coded waste chute dimensions #14147

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Delete some dead code. This was experimental crud left over from #13828.

Test Plan

None needed.

Review requests

None in particular.

Risk assessment

No risk.

@SyntaxColoring SyntaxColoring added the papi-v2 Python API V2 label Dec 7, 2023
@SyntaxColoring SyntaxColoring requested a review from a team December 7, 2023 23:17
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner December 7, 2023 23:17
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #14147 (52e8d4e) into chore_release-7.1.0 (cc212b2) will not change coverage.
Report is 1 commits behind head on chore_release-7.1.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.1.0   #14147   +/-   ##
====================================================
  Coverage                70.44%   70.44%           
====================================================
  Files                     2512     2512           
  Lines                    71224    71224           
  Branches                  8972     8972           
====================================================
  Hits                     50173    50173           
  Misses                   18857    18857           
  Partials                  2194     2194           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@SyntaxColoring SyntaxColoring merged commit 990b4ac into chore_release-7.1.0 Dec 8, 2023
25 checks passed
@SyntaxColoring SyntaxColoring deleted the delete_more_cruft branch December 8, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
papi-v2 Python API V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants