Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): properly display no liquids used text in protocol details/setup #14144

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Dec 7, 2023

closes RQA-2006

Overview

When we decide whether or not to display liquids in ProtocolDetails or ProtocolSetup, we need to determine if the liquids are actually loaded in protocol (commands) rather than accessing the liquids property of the protocol analysis.

Test Plan

  • create protocol that specifies liquids but does not load them in any wells example
  • upload protocol to App
  • confirm that ProtocolDetails and ProtocolSetup properly render "No liquids are specified for this protocol."
Screen Shot 2023-12-07 at 10 41 26 AM Screen Shot 2023-12-07 at 4 57 31 PM

Risk assessment

low

…etup

When we decide whether or not to display liquids in ProtocolDetails or ProtocolSetup, we need to
determine if the liquids are actually loaded in protocol (commands) rather than accessing the
liquids property of the protocol analysis.
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner December 7, 2023 21:57
@ncdiehl11 ncdiehl11 requested review from jerader and removed request for a team December 7, 2023 21:57
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #14144 (fb33407) into chore_release-7.1.0 (93c879a) will decrease coverage by 0.08%.
Report is 19 commits behind head on chore_release-7.1.0.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14144      +/-   ##
=======================================================
- Coverage                70.44%   70.37%   -0.08%     
=======================================================
  Files                     2512     2512              
  Lines                    71201    71475     +274     
  Branches                  8964     9100     +136     
=======================================================
+ Hits                     50161    50303     +142     
- Misses                   18849    18943      +94     
- Partials                  2191     2229      +38     
Flag Coverage Δ
app 67.35% <100.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...organisms/Devices/ProtocolRun/ProtocolRunSetup.tsx 81.91% <100.00%> (+0.39%) ⬆️
...ganisms/ProtocolDetails/ProtocolLiquidsDetails.tsx 90.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ncdiehl11 ncdiehl11 merged commit f7caea6 into chore_release-7.1.0 Dec 11, 2023
22 checks passed
@ncdiehl11 ncdiehl11 deleted the app_fix-no-liquids branch December 11, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants