feat(protocol-designer): remove 96-channel ff and add cypress migration test #14117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14117 +/- ##
=======================================
Coverage 70.36% 70.36%
=======================================
Files 2481 2481
Lines 70351 70345 -6
Branches 8790 8789 -1
=======================================
- Hits 49504 49500 -4
+ Misses 18690 18689 -1
+ Partials 2157 2156 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
force-pushed
the
pd_96-channel-ff-removal
branch
from
20ceb92 to
d58970e
Compare
jerader
commented
Dec 7, 2023
koji
reviewed
Dec 7, 2023
protocol-designer/src/components/modals/FilePipettesModal/PipetteFields.tsx
Outdated
Show resolved
Hide resolved
koji
approved these changes
Dec 7, 2023
jerader
force-pushed
the
pd_96-channel-ff-removal
branch
from
ecbf7a7 to
ae032ab
Compare
ncdiehl11
pushed a commit
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-840
Overview
removes the 96-channel feature flag and adds a cypress test case for migrating a protocol with a 96-channel. this is to prepare for the PD 8.0 release candidate
Test Plan
create a flex protocol and see that the 96-channel option is available to select! Create an ot-2 protocol and see that the 96-channel option is not available.
Changelog
Review requests
see test plan
Risk assessment
low