refactor(app, components, shared-data, protocol-designer, react-api-client): update to react 18 #14114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14114 +/- ##
==========================================
- Coverage 70.38% 68.13% -2.26%
==========================================
Files 2510 1632 -878
Lines 71292 54449 -16843
Branches 9019 4034 -4985
==========================================
- Hits 50179 37097 -13082
+ Misses 18901 16723 -2178
+ Partials 2212 629 -1583
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…lient): update to react 18 Update all react projects to react 18 and manage it's sub dependencies
b-cooper
changed the title
b-cooper
requested review from
a team and
shlokamin
and removed request for
brenthagen,
a team and
shlokamin
brenthagen
approved these changes
Dec 13, 2023
jerader
reviewed
Dec 14, 2023
There was a problem hiding this comment.
I did some smoke testing and its looking good for the most part. There are several cypress tests failing in PD. The batchEdit and mixSettings passes locally. But the migration tests are failing due to a modal upon import, which is a bit concerning to me. It would be great if we can investigate that before this merges in.
|
yeah lets fix those cypress tests — im looking into it now |
…s into chore_react-18-no-hmr
ncdiehl11
pushed a commit
that referenced
this pull request
Dec 19, 2023
…lient): update to react 18 (#14114) Update all react projects to react 18 and manage its sub dependencies Co-authored-by: Shlok Amin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update all react projects to react 18 and manage it's sub dependencies
Changelog
Review requests
Risk assessment
high