-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add tip tracking for partial tip configuration #14104
feat(api): add tip tracking for partial tip configuration #14104
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14104 +/- ##
=======================================================
- Coverage 70.44% 70.43% -0.01%
=======================================================
Files 1636 1636
Lines 54470 54470
Branches 4008 4008
=======================================================
- Hits 38369 38367 -2
- Misses 15407 15408 +1
- Partials 694 695 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tested the above protocol on Flex successfully! (Successful = pipette picked up next tips in correct order. Got an unrelated tip sensor error halfway in) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments from in-person review with @jbleon95 @CaseyBatten
|
||
def get_active_channels(self) -> int: | ||
"""This will never be called because it was added in API 2.16.""" | ||
return 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do an assert False with error message here instead of returning random number
|
||
def get_active_channels(self) -> int: | ||
"""This will never be called because it was added in API 2.16.""" | ||
return 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
self._handle_command(action.command) | ||
# TODO: add test for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove todo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Held in person review, changes look good, nothing blocking.
Closes RSS-299
Overview
Adds automatic tip selection for pipettes in partial tip configuration. Also updates signature of
configure_nozzle_layout
to include list of tip racks to use during the configuration.Test Plan
Sample protocol for testing.
Changelog
active_channels
getter to get the number of pipette channels that are actually in useReview requests
Risk assessment
Medium. Affects existing tip tracking logic