feat(protocol-designer): remove deck config ff and add deck config cypress test #14096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14096 +/- ##
=======================================
Coverage 70.36% 70.36%
=======================================
Files 2481 2481
Lines 70351 70325 -26
Branches 8790 8780 -10
=======================================
- Hits 49504 49486 -18
+ Misses 18690 18687 -3
+ Partials 2157 2152 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
force-pushed
the
pd_remove-deck-config-ff
branch
from
d5f4c7a to
1064944
Compare
jerader
force-pushed
the
pd_remove-deck-config-ff
branch
from
272e280 to
1df5f32
Compare
jerader
commented
Dec 7, 2023
jerader
force-pushed
the
pd_remove-deck-config-ff
branch
from
1df5f32 to
83a4e72
Compare
jerader
commented
Dec 7, 2023
| @@ -1,6 +1,6 @@ | |||
| import { OutputSelector, Selector } from 'reselect' | |||
| declare module 'reselect' { | |||
| // declaring type for createSelector with 15 selectors because the reselect types only support up to 12 selectors | |||
| // declaring type for createSelector with 14 selectors because the reselect types only support up to 12 selectors | |||
There was a problem hiding this comment.
this change is needed since i removed the getAdditionalEquipmentEntities selector from fileCreator
koji
reviewed
Dec 7, 2023
protocol-designer/src/components/modals/CreateFileWizard/ModulesAndOtherTile.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-876 RAUT-842 RAUT-841
Overview
To prepare for the 8.0 PD release, this PR removes the deck configuration ff and adds a cypress migration test with staging area slots and waste chute
Test Plan
Do a quick smoke test, go through creating a protocol with staging area slots and the waste chute. Try editing them in the Additional Items section. See that it all works as expected.
Changelog
Review requests
see test plan
Risk assessment
low