-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): adapt deck location select for OT-2 deck definition v4 #14078
feat(components): adapt deck location select for OT-2 deck definition v4 #14078
Conversation
implements the v4 version of deck location select for OT-2. used by drop tip wizard. uses v3 DeckFromLayers in the same way as BaseDeck. closes RQA-1951
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14078 +/- ##
=======================================================
- Coverage 70.46% 70.44% -0.03%
=======================================================
Files 2512 2512
Lines 71203 71287 +84
Branches 8958 9001 +43
=======================================================
+ Hits 50176 50218 +42
- Misses 18833 18872 +39
- Partials 2194 2197 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! PD failures seem unrelated. Will get the savePosition PR changes up asap.
Overview
implements the v4 version of deck location select for OT-2. used by drop tip wizard. uses v3 DeckFromLayers in the same way as BaseDeck.
closes RQA-1951
Test Plan
Changelog
Review requests
check functionality of drop tip wizard for OT-2
Risk assessment
low