Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): adapt deck location select for OT-2 deck definition v4 #14078

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

brenthagen
Copy link
Contributor

@brenthagen brenthagen commented Dec 1, 2023

Overview

implements the v4 version of deck location select for OT-2. used by drop tip wizard. uses v3 DeckFromLayers in the same way as BaseDeck.

closes RQA-1951

Screen Shot 2023-12-05 at 11 20 11 AM Screen Shot 2023-12-05 at 11 20 15 AM

Test Plan

  • manually verifed rendering and functionality

Changelog

  • Adapts deck location select for OT-2 deck definition v4

Review requests

check functionality of drop tip wizard for OT-2

Risk assessment

low

implements the v4 version of deck location select for OT-2. used by drop tip wizard. uses v3
DeckFromLayers in the same way as BaseDeck.

closes RQA-1951
@brenthagen brenthagen requested a review from a team December 1, 2023 16:23
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #14078 (bf39a97) into chore_release-7.1.0 (c5a8bf4) will decrease coverage by 0.03%.
Report is 6 commits behind head on chore_release-7.1.0.
The diff coverage is 13.63%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14078      +/-   ##
=======================================================
- Coverage                70.46%   70.44%   -0.03%     
=======================================================
  Files                     2512     2512              
  Lines                    71203    71287      +84     
  Branches                  8958     9001      +43     
=======================================================
+ Hits                     50176    50218      +42     
- Misses                   18833    18872      +39     
- Partials                  2194     2197       +3     
Flag Coverage Δ
app 67.59% <ø> (-0.08%) ⬇️
components 59.86% <13.63%> (-0.28%) ⬇️
labware-library 51.50% <ø> (ø)
protocol-designer 44.99% <ø> (+0.03%) ⬆️
shared-data 75.02% <ø> (+<0.01%) ⬆️
step-generation 86.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
shared-data/js/fixtures.ts 17.85% <ø> (ø)
...mponents/src/hooks/useSelectDeckLocation/index.tsx 60.52% <30.00%> (-7.22%) ⬇️
...onents/src/hardware-sim/DeckSlotLocation/index.tsx 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

@brenthagen brenthagen marked this pull request as ready for review December 5, 2023 16:25
@brenthagen brenthagen requested review from a team as code owners December 5, 2023 16:25
@brenthagen brenthagen requested review from ncdiehl11 and removed request for a team and ncdiehl11 December 5, 2023 16:25
@brenthagen brenthagen changed the base branch from edge to chore_release-7.1.0 December 5, 2023 19:28
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! PD failures seem unrelated. Will get the savePosition PR changes up asap.

@brenthagen brenthagen merged commit bd38336 into chore_release-7.1.0 Dec 7, 2023
50 of 53 checks passed
@brenthagen brenthagen deleted the components_ot2-deck-location-select branch December 7, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants