Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): Rename EMPTY to ALL for partial tip API #14034

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

Laura-Danielle
Copy link
Contributor

Overview

The good people of Opentrons have decreed that EMPTY shall henceforth be named ALL. That is ALL.

@Laura-Danielle Laura-Danielle requested review from a team as code owners November 21, 2023 19:16
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #14034 (af99121) into edge (5367bdd) will decrease coverage by 0.02%.
Report is 4 commits behind head on edge.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14034      +/-   ##
==========================================
- Coverage   70.63%   70.61%   -0.02%     
==========================================
  Files        2507     2507              
  Lines       70987    71122     +135     
  Branches     8805     8874      +69     
==========================================
+ Hits        50139    50221      +82     
- Misses      18683    18728      +45     
- Partials     2165     2173       +8     
Flag Coverage Δ
app 67.57% <ø> (-0.10%) ⬇️
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)
protocol-designer 45.62% <ø> (ø)
shared-data 73.61% <ø> (ø)
step-generation 86.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/src/opentrons/protocol_api/__init__.py 100.00% <ø> (ø)
...i/src/opentrons/protocol_api/instrument_context.py 89.49% <ø> (ø)
api/src/opentrons/protocol_engine/__init__.py 100.00% <ø> (ø)
api/src/opentrons/protocol_engine/types.py 97.50% <ø> (ø)

... and 8 files with indirect coverage changes

Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I updated the separate dosctring PR is to reflect this change.

I'll defer to an engineer to give ✅ to the code.

Copy link
Member

@sanni-t sanni-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALL is well

@Laura-Danielle Laura-Danielle merged commit 9f37c38 into edge Nov 22, 2023
58 checks passed
@Laura-Danielle Laura-Danielle deleted the refactor-modify-name-of-empty branch November 22, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants