-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): Add warning for 96-channel calibration with waste chute #14031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14031 +/- ##
==========================================
- Coverage 70.63% 70.61% -0.02%
==========================================
Files 2507 2507
Lines 70984 71010 +26
Branches 8802 8821 +19
==========================================
+ Hits 50139 50147 +8
- Misses 18680 18688 +8
- Partials 2165 2175 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
reviewed
Nov 20, 2023
koji
reviewed
Nov 20, 2023
koji
reviewed
Nov 20, 2023
koji
reviewed
Nov 20, 2023
koji
reviewed
Nov 20, 2023
smb2268
force-pushed
the
app_waste-chute-warning
branch
from
November 20, 2023 22:36
e01a135
to
445ec86
Compare
ecormany
reviewed
Nov 21, 2023
mjhuff
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-1883, RQA-1897, RAUT-848
Overview
This PR adds a warning to calibration flows that use a 96 channel telling users to detach the waste chute before calibrating. It also updates some styling and copy of banners in these flows to match designs.
Test Plan
With a 96-channel attached, initiate both calibration and module calibration flows. Ensure the following is true:
Changelog
Review requests
Test this out if you can! Should be doable with a simulator
Risk assessment
Low