Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add warning for 96-channel calibration with waste chute #14031

Merged
merged 7 commits into from
Nov 21, 2023

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Nov 20, 2023

fix RQA-1883, RQA-1897, RAUT-848

Overview

This PR adds a warning to calibration flows that use a 96 channel telling users to detach the waste chute before calibrating. It also updates some styling and copy of banners in these flows to match designs.

Test Plan

With a 96-channel attached, initiate both calibration and module calibration flows. Ensure the following is true:

  1. For pipette cal, if no waste chute is in the deck config you should see a yellow warning on both the before beginning and attach probe screens
  2. If the waste chute is in the deck config, this should be a red banner instead of yellow
  3. For module calibration, the same logic should apply to the attach probe screen only if there is a module in slot C3 being calibrated

Changelog

  1. Add banner for waste chute collision to pipette cal before beginning and attach probe and module cal attach probe screen
  2. Move all banners in pipette flows to below the body text instead of above it
  3. Update copy and padding to match designs
  4. Fix styling bug on LPC early exit screen

Review requests

Test this out if you can! Should be doable with a simulator

Risk assessment

Low

@smb2268 smb2268 self-assigned this Nov 20, 2023
@smb2268 smb2268 requested a review from a team as a code owner November 20, 2023 22:11
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #14031 (fd948d6) into edge (7239a53) will decrease coverage by 0.02%.
Report is 2 commits behind head on edge.
The diff coverage is 34.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14031      +/-   ##
==========================================
- Coverage   70.63%   70.61%   -0.02%     
==========================================
  Files        2507     2507              
  Lines       70984    71010      +26     
  Branches     8802     8821      +19     
==========================================
+ Hits        50139    50147       +8     
- Misses      18680    18688       +8     
- Partials     2165     2175      +10     
Flag Coverage Δ
app 67.62% <34.28%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/molecules/GenericWizardTile/index.tsx 88.88% <100.00%> (+0.42%) ⬆️
...rganisms/LabwarePositionCheck/ExitConfirmation.tsx 71.42% <ø> (ø)
.../src/organisms/PipetteWizardFlows/MountPipette.tsx 94.73% <100.00%> (ø)
...src/organisms/PipetteWizardFlows/DetachPipette.tsx 54.76% <66.66%> (-0.24%) ⬇️
...c/organisms/PipetteWizardFlows/BeforeBeginning.tsx 79.10% <60.00%> (-3.95%) ⬇️
...p/src/organisms/PipetteWizardFlows/AttachProbe.tsx 69.64% <28.57%> (-5.87%) ⬇️
...pp/src/organisms/ModuleWizardFlows/AttachProbe.tsx 6.66% <0.00%> (-1.45%) ⬇️

... and 2 files with indirect coverage changes

@smb2268 smb2268 force-pushed the app_waste-chute-warning branch from e01a135 to 445ec86 Compare November 20, 2023 22:36
@smb2268 smb2268 requested review from koji and ecormany November 21, 2023 15:54
@smb2268 smb2268 requested a review from mjhuff November 21, 2023 19:27
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@smb2268 smb2268 merged commit df057fd into edge Nov 21, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants