refactor(robot-server,api-client): Rename GET /deck_configuration field lastUpdatedAt to lastModifiedAt
#14029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
added
robot server
SyntaxColoring
changed the title
GET /deck_configuration field lastUpdatedAt to lastModifiedAtGET /deck_configuration field lastUpdatedAt to lastModifiedAt
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14029 +/- ##
=======================================
Coverage 70.63% 70.63%
=======================================
Files 2507 2507
Lines 70984 70984
Branches 8802 8802
=======================================
Hits 50139 50139
Misses 18680 18680
Partials 2165 2165
Flags with carried forward coverage won't be shown. Click here to find out more. |
mjhuff
approved these changes
Nov 20, 2023
jerader
approved these changes
Nov 20, 2023
|
|
SyntaxColoring
force-pushed
the
lastupdatedat_lastmodifiedat
branch
from
36f4f34 to
0bb3adb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When I added the
GET /deck_configurationendpoint, I gave it alastUpdatedAtfield.That name is accidentally inconsistent with our calibration endpoints (deck, pipette, etc.), which instead use
lastModified.This PR changes
lastUpdatedAttolastModifiedAt.I'm deliberately keeping the
Atsuffix because that has been an intentional naming convention of our HTTP API going forward. (Protocol Engine hascreatedAt,completedAt, etc.) So that's an intentional inconsistency.Test Plan
None applicable. As far as I can tell, there's not yet any app code that reads this field.
Changelog
lastUpdatedAtfield inGET /deck_configurationtolastModifiedAt.Review requests
None in particular.
Risk assessment
Low for now, since nothing uses this yet.