Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): wire up protocol setup fixture view setup instructions link #14021

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Nov 17, 2023

Overview

wire up protocol setup fixture view setup instructions link

close RAUT-870

Test Plan

  1. setup a protocol
  2. go to modules & deck
  3. click view setup instructions link in Fixture list

Changelog

  • update SetupFixtureList and its test

Review requests

Risk assessment

low

… link

wire up protocol setup fixture view setup instructions link

close RAUT-870
@koji koji requested review from brenthagen, mjhuff, jerader and a team November 17, 2023 21:49
@koji koji marked this pull request as ready for review November 17, 2023 21:49
@koji koji requested a review from a team as a code owner November 17, 2023 21:49
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #14021 (cf8727e) into edge (aedf573) will increase coverage by 0.02%.
Report is 4 commits behind head on edge.
The diff coverage is 60.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14021      +/-   ##
==========================================
+ Coverage   70.49%   70.52%   +0.02%     
==========================================
  Files        1586     2465     +879     
  Lines       51507    68374   +16867     
  Branches     3865     8868    +5003     
==========================================
+ Hits        36311    48222   +11911     
- Misses      14523    17977    +3454     
- Partials      673     2175    +1502     
Flag Coverage Δ
app 67.74% <60.00%> (+29.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rotocolRun/SetupModuleAndDeck/SetupFixtureList.tsx 55.55% <60.00%> (ø)

... and 879 files with indirect coverage changes

Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@koji koji merged commit 0002ebd into edge Nov 17, 2023
21 of 22 checks passed
@koji koji deleted the feat_add-setup-instructions-link branch November 17, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants