Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shared-data): Adds P1000S model 3.6 to shared data, with new function for 1000ul tips #14009

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

andySigler
Copy link
Contributor

Overview

New function for just the 1000ul tip on the P1000S greatly increases production yield.

Test Plan

Changelog

Review requests

Risk assessment

@andySigler andySigler requested a review from a team as a code owner November 16, 2023 20:10
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #14009 (4b3e4fc) into edge (2c83a19) will decrease coverage by 0.03%.
Report is 1 commits behind head on edge.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14009      +/-   ##
==========================================
- Coverage   70.68%   70.65%   -0.03%     
==========================================
  Files        1628     2507     +879     
  Lines       54246    70933   +16687     
  Branches     3858     8775    +4917     
==========================================
+ Hits        38343    50121   +11778     
- Misses      15236    18661    +3425     
- Partials      667     2151    +1484     
Flag Coverage Δ
app 67.69% <ø> (+29.12%) ⬆️
components 62.56% <ø> (ø)
labware-library 51.50% <ø> (ø)
protocol-designer 45.67% <ø> (ø)
shared-data 73.57% <ø> (ø)
step-generation 86.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 880 files with indirect coverage changes

@andySigler andySigler marked this pull request as draft November 28, 2023 19:00
@andySigler andySigler changed the base branch from edge to chore_release-7.1.0 December 5, 2023 19:45
@andySigler andySigler marked this pull request as ready for review December 5, 2023 19:45
@andySigler andySigler requested a review from sfoster1 December 5, 2023 19:46
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sfoster1 sfoster1 merged commit 5a33ab4 into chore_release-7.1.0 Dec 5, 2023
71 of 74 checks passed
@andySigler andySigler deleted the feat-shared-data-pipette-model-3.6 branch December 19, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants