Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, component): dqa device detail deck configurator #14007

Merged
merged 12 commits into from
Nov 17, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Nov 16, 2023

Overview

DQA for Device Detail Deck Configurator

Update slot label text
Address the comment
Add No deck fixtures

  • When flexing down, deck map could go center aligned and the list goes underneath the deck config as full width
    I will work on ↑ in a following PR. Seems that SlotLabel size is varied by Deck Configurator size so if we use the size in Figma the label is hard to read.
    Additionally, if the app window width exceeds 1130px, the huge white space shows up which doesn't look good.
    Asking about these to Rob.

The interaction part was already implemented.

close RAUT-831

Test Plan

  • Go to Device Detail page

Changelog

  • update label font size
  • add No deck fixtures and its test

Review requests

Risk assessment

low

dqa device detail deck configurator

close RAUT-831
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #14007 (50483ae) into edge (cc9b876) will increase coverage by 0.01%.
Report is 1 commits behind head on edge.
The diff coverage is 62.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14007      +/-   ##
==========================================
+ Coverage   70.49%   70.50%   +0.01%     
==========================================
  Files        1586     2466     +880     
  Lines       51506    68212   +16706     
  Branches     3864     8793    +4929     
==========================================
+ Hits        36311    48096   +11785     
- Misses      14522    17953    +3431     
- Partials      673     2163    +1490     
Flag Coverage Δ
app 67.66% <0.00%> (+29.09%) ⬆️
components 62.61% <66.66%> (+0.04%) ⬆️
labware-library 51.50% <ø> (ø)
protocol-designer 45.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rdware-sim/DeckConfigurator/EmptyConfigFixture.tsx 75.00% <ø> (-3.58%) ⬇️
...-sim/DeckConfigurator/StagingAreaConfigFixture.tsx 8.33% <ø> (-5.96%) ⬇️
...are-sim/DeckConfigurator/TrashBinConfigFixture.tsx 7.69% <ø> (-5.65%) ⬇️
...nts/src/hardware-sim/DeckConfigurator/constants.ts 100.00% <100.00%> (ø)
components/src/ui-style-constants/typography.ts 100.00% <100.00%> (ø)
...organisms/DeviceDetailsDeckConfiguration/index.tsx 64.51% <0.00%> (ø)
...onents/src/hardware-sim/DeckConfigurator/index.tsx 70.00% <60.00%> (-3.08%) ⬇️
...e-sim/DeckConfigurator/WasteChuteConfigFixture.tsx 7.14% <0.00%> (-7.15%) ⬇️

... and 879 files with indirect coverage changes

@koji koji requested review from brenthagen, mjhuff, a team, ncdiehl11 and jerader November 16, 2023 19:57
@koji koji marked this pull request as ready for review November 16, 2023 19:57
@koji koji requested a review from a team as a code owner November 16, 2023 19:57
@koji koji removed the request for review from a team November 16, 2023 19:57
@koji koji marked this pull request as draft November 16, 2023 20:30
@brenthagen
Copy link
Contributor

let's remove the wasteChuteDef in WasteChuteConfigFixture as well as trashBinDef, stagingAreaDef, and standardSlotDef in the other config fixture components and instead define shared constants in a constants.ts file in the deck configurator directory: SINGLE_SLOT_FIXTURE_WIDTH, STAGING_AREA_FIXTURE_WIDTH, and FIXTURE_HEIGHT to pass to all of the config fixture foreign object components.

as far as i'm aware, we will not be defining fixture dimensions by JSON file or otherwise in shared-data, so let's just do it here for these components

@koji koji marked this pull request as ready for review November 16, 2023 22:47
@brenthagen
Copy link
Contributor

font size and line height should change for waste chute config fixture also - can we define a const smallBodyTextSemiBold in typography?
Screen Shot 2023-11-16 at 5 54 10 PM

@koji koji requested a review from a team as a code owner November 17, 2023 16:01
@koji koji requested a review from brenthagen November 17, 2023 17:21
app.py Outdated Show resolved Hide resolved
used a wrong repo
@koji koji removed the request for review from a team November 17, 2023 19:42
@koji koji marked this pull request as draft November 17, 2023 19:42
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@koji koji marked this pull request as ready for review November 17, 2023 21:20
@koji koji merged commit 650944e into edge Nov 17, 2023
43 of 44 checks passed
@koji koji deleted the app_dqa-desktop-device-details-deck-config branch November 17, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants