-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app, component): dqa device detail deck configurator #14007
Conversation
dqa device detail deck configurator close RAUT-831
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14007 +/- ##
==========================================
+ Coverage 70.49% 70.50% +0.01%
==========================================
Files 1586 2466 +880
Lines 51506 68212 +16706
Branches 3864 8793 +4929
==========================================
+ Hits 36311 48096 +11785
- Misses 14522 17953 +3431
- Partials 673 2163 +1490
Flags with carried forward coverage won't be shown. Click here to find out more.
|
let's remove the as far as i'm aware, we will not be defining fixture dimensions by JSON file or otherwise in |
used a wrong repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Overview
DQA for Device Detail Deck Configurator
Update slot label text
Address the comment
Add No deck fixtures
I will work on ↑ in a following PR. Seems that
SlotLabel
size is varied by Deck Configurator size so if we use the size in Figma the label is hard to read.Additionally, if the app window width exceeds 1130px, the huge white space shows up which doesn't look good.
Asking about these to Rob.
The interaction part was already implemented.
close RAUT-831
Test Plan
Changelog
Review requests
Risk assessment
low