refactor(app): replace RobotWorkSpace with BaseDeck in ProtocolSetup Liquids #13918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Liquids replace RobotWorkSpace with BaseDeck in ProtocolSetup Liquids close RAUT-821
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13918 +/- ##
========================================
Coverage 70.62% 70.63%
========================================
Files 2481 2509 +28
Lines 69984 70748 +764
Branches 8525 8681 +156
========================================
+ Hits 49426 49970 +544
- Misses 18465 18655 +190
- Partials 2093 2123 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Need to merge #13875 first then update this PR |
|
brenthagen
approved these changes
Nov 7, 2023
app/src/organisms/Devices/ProtocolRun/SetupLiquids/SetupLiquidsMap.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/Devices/ProtocolRun/SetupLiquids/SetupLiquidsMap.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/Devices/ProtocolRun/SetupLiquids/SetupLiquidsMap.tsx
Outdated
Show resolved
Hide resolved
…hub.com/Opentrons/opentrons into app_refactor-replace-deckmap-in-liquids
ncdiehl11
pushed a commit
that referenced
this pull request
Nov 14, 2023
…Liquids (#13918) * refactor(app): replace RobotWorkSpace with BaseDeck in ProtocolSetup Liquids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
replace
RobotWorkSpacewithBaseDeckin ProtocolSetup LiquidsAt this moment, tests don't cover everything, so I will do refactoring later and add tests.
close RAUT-821
Test Plan
test_liquid_check_for_base-deck.py.zip
Setup a protocol
Changelog
Review requests
Risk assessment
low