fix(labware-library): remove python test protocol affordances from labware-creator #13896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om labware-creator The utility of the python test protocol generated from the labware creator has worn-down and been replaced by other more helpful trouble shooting tools. Return the labware json file by itself instead of a zip Closes RAUT-198
|
looks like u gotta update a snapshot test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #13896 +/- ##
==========================================
+ Coverage 67.33% 68.02% +0.68%
==========================================
Files 2485 1617 -868
Lines 71386 54730 -16656
Branches 9030 4107 -4923
==========================================
- Hits 48069 37231 -10838
+ Misses 21173 16841 -4332
+ Partials 2144 658 -1486
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
approved these changes
Dec 5, 2023
|
Hooray! Might want to call this a |
…bware-creator Remove the python test protocol generated with custom labware output from the labware creator. There are more helpful troubleshooting tools elsewhere in the ecosystem. Return only the JSON file instead of a zip archive Closes RAUT-198, Closes RAUT-199, Closes RAUT-200, Closes RAUT-202
b-cooper
changed the title
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
…bware-creator (#13896) # Overview The utility of the python test protocol generated from the labware creator has worn-down and been replaced by other more helpful trouble shooting tools. Return the labware json file by itself instead of a zip Closes [RAUT-198](https://opentrons.atlassian.net/browse/RAUT-198) Closes RAUT-199 Closes RAUT-200 Closes RAUT-202 # Risk assessment medium, large chunk of code removal [RAUT-198]: https://opentrons.atlassian.net/browse/RAUT-198?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The utility of the python test protocol generated from the labware creator has worn-down and been
replaced by other more helpful trouble shooting tools. Return the labware json file by itself
instead of a zip
Closes RAUT-198
Closes RAUT-199
Closes RAUT-200
Closes RAUT-202
Risk assessment
medium, large chunk of code removal