feat(app): oDD labware setup map migration to using baseDeck #13858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
brenthagen,
koji and
a team
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13858 +/- ##
=======================================
Coverage 70.85% 70.85%
=======================================
Files 2496 2497 +1
Lines 70198 70225 +27
Branches 8568 8576 +8
=======================================
+ Hits 49736 49761 +25
- Misses 18381 18382 +1
- Partials 2081 2082 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
brenthagen
approved these changes
Oct 27, 2023
| labwareLocations: mockLabwareLocations, | ||
| moduleLocations: mockModuleLocations, | ||
| }) | ||
| .mockReturnValue(<div>mock base deck</div>) |
There was a problem hiding this comment.
not critical, a simple way to test the component logic would be to render something from mockProtocolModuleInfo in this base deck mock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-822
Overview
Splits the modal into its own component and then updates the map render to use base deck.
Test Plan
Upload a protocol to the ODD and look at labware setup map view. See that the deck rendering correctly and clicking on the labware opens the correct labware details modal.
Changelog
baseDeckto haveonLabwareClickpropLabwareMapViewModaland create testProtocolSetupLabwareReview requests
see test plan
Risk assessment
low