Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pypi deploys of api and shared-data #13793

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Oct 16, 2023

These need to get uploaded to pypi and were not because of some kind of version conflict in api. With a bit of judicious pipenv relocking all is well.

In theory everybody would need to relock but really nobody's running twine so it's fine.

Testing

These need to get uploaded to pypi and were not because of some kind of
version conflict in api. With a bit of judicious pipenv relocking all is
well.
@sfoster1 sfoster1 requested review from a team as code owners October 16, 2023 18:33
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #13793 (26f90d2) into chore_release-7.0.1 (dfb7acb) will increase coverage by 0.02%.
Report is 2 commits behind head on chore_release-7.0.1.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.1   #13793      +/-   ##
=======================================================
+ Coverage                71.22%   71.25%   +0.02%     
=======================================================
  Files                     2432     1589     -843     
  Lines                    68407    52767   -15640     
  Branches                  8047     3453    -4594     
=======================================================
- Hits                     48724    37598   -11126     
+ Misses                   17793    14634    -3159     
+ Partials                  1890      535    -1355     
Flag Coverage Δ
app 43.57% <ø> (-25.22%) ⬇️
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)
protocol-designer 46.09% <ø> (ø)
step-generation 86.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 845 files with indirect coverage changes

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey dokey artichokey. 🕺

@sfoster1 sfoster1 merged commit 791dbe7 into chore_release-7.0.1 Oct 16, 2023
@sfoster1 sfoster1 deleted the fix-pypi-deploys branch October 16, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants