Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): wire up staging areas to loadFixture commands #13759

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Oct 11, 2023

closes RAUT-744 RAUT-770

Overview

Wires up the staging areas to create loadFixture commands and when you import a protocol back to PD, the loadFixture commands get populated back as staging areas in redux

Test Plan

Make sure the deck configuration ff is turned on and add a staging area in the create file wizard. Export the protocol. Open the json file and see that there is a loadFixture command associated with the staging area and location that you added.

Change the version in the json file from 7.0.0-candidate-d to 7.1 so the protocol doesn't unnecessarily go through a migration. Then import the protocol back into PD. Open dev tools and look at StepForms -> additionalEquipmentInvariantProperties and see that the staging area entities are there.

Changelog

  • add logic for import/export to manage the staging areas
  • fix the import order on the files

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team October 11, 2023 17:04
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #13759 (30c4d15) into edge (f28fe32) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13759   +/-   ##
=======================================
  Coverage   70.94%   70.94%           
=======================================
  Files        2455     2455           
  Lines       69086    69086           
  Branches     8268     8268           
=======================================
  Hits        49013    49013           
  Misses      18118    18118           
  Partials     1955     1955           
Flag Coverage Δ
protocol-designer 45.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ol-designer/src/file-data/selectors/fileCreator.ts 64.86% <ø> (ø)
protocol-designer/src/step-forms/reducers/index.ts 52.56% <ø> (ø)

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jerader jerader merged commit d16b7ec into edge Oct 16, 2023
22 checks passed
@jerader jerader deleted the pd_load-fixture-staging-area branch October 16, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants