Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix small bugs on ODD #13618

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix(app): fix small bugs on ODD #13618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/assets/localization/en/run_details.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"comment_step": "Comment",
"comment": "Comment",
"complete_protocol_to_download": "Complete the protocol to download the run log",
"contact_information": "Download the run logs from the Opentrons App and send it to [email protected] for assistance.",
"contact_information": "Download the robot logs from the Opentrons App and send it to [email protected] for assistance.",
"current_step_pause_timer": "Timer",
"current_step_pause": "Current Step - Paused by User",
"current_step": "Current Step",
Expand Down
8 changes: 7 additions & 1 deletion app/src/organisms/OnDeviceDisplay/RunningProtocol/RunFailedModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,13 @@ export function RunFailedModal({
</StyledText>
</Flex>
</Flex>
<StyledText as="p" textAlign={TYPOGRAPHY.textAlignLeft}>
<StyledText
as="p"
textAlign={TYPOGRAPHY.textAlignLeft}
css={css`
word-break: break-word;
`}
Comment on lines +105 to +107
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using css since wordBreak="break-word" doesn't work.
I think at some point we would need to update StyleProps to add new css properties.
I guess we will be able to work on this when we start working on the design system unification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree. It would make things a bit easier.

>
{t('contact_information')}
</StyledText>
</Flex>
Expand Down
2 changes: 1 addition & 1 deletion app/src/organisms/OnDeviceDisplay/RunningProtocol/__tests__/RunFailedModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ describe('RunFailedModal', () => {
getByText('Error 1000: hardwareCommunicationError')
getByText('Error with code 1000 (highest priority)')
getByText(
'Download the run logs from the Opentrons App and send it to [email protected] for assistance.'
'Download the robot logs from the Opentrons App and send it to [email protected] for assistance.'
)
getByText('Close')
})
Expand Down
1 change: 0 additions & 1 deletion app/src/pages/OnDeviceDisplay/RunSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ const SplashFrame = styled(Flex)`
const ProtocolName = styled.h4`
font-weight: ${TYPOGRAPHY.fontWeightSemiBold};
text-align: ${TYPOGRAPHY.textAlignLeft};
text-transform: ${TYPOGRAPHY.textTransformCapitalize};
font-size: ${TYPOGRAPHY.fontSize28};
line-height: ${TYPOGRAPHY.lineHeight36};
color: ${COLORS.darkBlack70};
Expand Down