fix(app): sort current offsets by date to ensure order #13563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-722 and RQA-1608
Overview
The data fetched from the runQuery hook does guarantee that the current offsets return in the same order. To fix this, I added sorting via
createdAt
from the offsets keyTest Plan
see the ticket attached, basically run LPC on desktop with offsets already in the table. Make sure they don't reorder during LPC. The reordering starts after the initial page of the LPC flow and ends when you complete LPC
Changelog
added sorting of the current offsets
Review requests
see test plan
Risk assessment
low