Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app) App thermocycler run preview style fix #13539

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Sep 13, 2023

Closes RQA-747

Overview

This PR fixes run preview commands involving the thermocycler profile to have styles consistent with other run preview steps.

Before

Screenshot 2023-09-13 at 8 48 59 AM

After

Screenshot 2023-09-13 at 8 49 08 AM

Test Plan

  • Upload a protocol that makes use of the thermocycler profile
    (Here is one ThermocyclerTest.py.zip)
  • Setup the protocol for running and go to Run Preview.
  • Scroll down to the step involving the thermocycler profile. Observe text is now consistent.

Changelog

  • Adjusted thermocycler case to stylistically match other run preview commands.

Risk assessment

low

Fixes run preview commands involving the thermocycler profile to have styles consistent with other
run preview steps.
@mjhuff mjhuff requested a review from a team September 13, 2023 12:56
@mjhuff mjhuff requested a review from a team as a code owner September 13, 2023 12:56
@mjhuff mjhuff requested review from koji and removed request for a team September 13, 2023 12:56
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #13539 (667ad12) into chore_release-7.0.0 (2d81953) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.0.0   #13539   +/-   ##
====================================================
  Coverage                71.31%   71.31%           
====================================================
  Files                     2420     2420           
  Lines                    68081    68081           
  Branches                  7907     7907           
====================================================
  Hits                     48549    48549           
  Misses                   17680    17680           
  Partials                  1852     1852           
Flag Coverage Δ
app 68.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
app/src/organisms/CommandText/index.tsx 84.61% <ø> (ø)

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 🖌️

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjhuff mjhuff merged commit 69decb1 into chore_release-7.0.0 Sep 13, 2023
@mjhuff mjhuff deleted the app_thermocycler_run_preview_style_fix branch September 13, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants