Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): interventional modal test remove link #13527

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Sep 12, 2023

Overview

Accidentally merged Brian's PR that has been sitting for awhile with an approval without realizing that a test was failing. This fixes the test

Test Plan

see that all checks pass!

Changelog

fix intervention modal test by commenting out the link test info that is commented out in the component

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner September 12, 2023 17:25
@jerader jerader requested review from b-cooper and removed request for a team September 12, 2023 17:25
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yoU!

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #13527 (34a12bb) into chore_release-7.0.0 (803bf9c) will decrease coverage by 0.02%.
Report is 2 commits behind head on chore_release-7.0.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13527      +/-   ##
=======================================================
- Coverage                71.33%   71.31%   -0.02%     
=======================================================
  Files                     1586     2418     +832     
  Lines                    52769    68012   +15243     
  Branches                  3435     7898    +4463     
=======================================================
+ Hits                     37642    48502   +10860     
- Misses                   14598    17663    +3065     
- Partials                   529     1847    +1318     
Flag Coverage Δ
app 68.92% <ø> (+24.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 832 files with indirect coverage changes

@jerader jerader requested a review from a team September 12, 2023 17:28
@jerader jerader force-pushed the app_fix-intervention-modal-link branch from a62a40f to fcc9867 Compare September 12, 2023 17:58
@jerader jerader merged commit fd5cea2 into chore_release-7.0.0 Sep 12, 2023
22 checks passed
@jerader jerader deleted the app_fix-intervention-modal-link branch September 12, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants