Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardware-testing changes to get low-volume pipetting working #13523

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

andySigler
Copy link
Contributor

Overview

Test on a grav fixture, and got same performance as with previous script implementation. Test both 1uL and 50uL on a PVT P50 Single.

Uses OT3API instead of InstrumentContext because the gravimetric script uses legacy core still, and push-out is not implemented in legacy core.

Test Plan

Changelog

Review requests

Risk assessment

@andySigler andySigler requested a review from sfoster1 September 12, 2023 15:53
@andySigler andySigler requested a review from a team as a code owner September 12, 2023 15:53
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if tests all pass!

@andySigler andySigler merged commit 1f47e0c into low-volume-pipetting Sep 12, 2023
6 checks passed
@andySigler andySigler deleted the low-volume-pipette-HW-TEST branch September 12, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants