Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app) dqa software keyboard round3 #13493

Merged
merged 7 commits into from
Sep 12, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Sep 7, 2023

Overview

address software keyboard feedback
change the folder structure for software keyboard components and add index.css to each component.

close RAUT-615

Test Plan

  1. run make -C components dev
  2. go to ODD software keyboard
    or
  3. push this branch to dev kit/Flex
  4. robot settings -> rename robot (CustomKeyboard)
  5. robot settings -> wifi settings -> password (NormalKeyboard)

Changelog

Review requests

Risk assessment

low

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #13493 (2863628) into chore_release-7.0.0 (fdf6e22) will increase coverage by 0.01%.
Report is 17 commits behind head on chore_release-7.0.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13493      +/-   ##
=======================================================
+ Coverage                71.32%   71.34%   +0.01%     
=======================================================
  Files                     2427     2429       +2     
  Lines                    67943    68481     +538     
  Branches                  7880     8114     +234     
=======================================================
+ Hits                     48462    48855     +393     
- Misses                   17627    17736     +109     
- Partials                  1854     1890      +36     
Flag Coverage Δ
app 68.91% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/atoms/SoftwareKeyboard/CustomKeyboard/index.tsx 90.90% <ø> (ø)
...rc/atoms/SoftwareKeyboard/NormalKeyboard/index.tsx 73.68% <ø> (ø)
app/src/atoms/SoftwareKeyboard/Numpad/index.tsx 100.00% <ø> (ø)

... and 25 files with indirect coverage changes

@koji koji requested a review from a team September 7, 2023 20:53
@koji koji marked this pull request as ready for review September 7, 2023 20:53
@koji koji requested a review from a team as a code owner September 7, 2023 20:53
@koji koji requested review from brenthagen and removed request for a team and brenthagen September 7, 2023 20:53
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! left a question about the import paths

@koji koji merged commit 250bc74 into chore_release-7.0.0 Sep 12, 2023
22 checks passed
@koji koji deleted the fix-software-keyboard-round3 branch September 12, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants