fix(app): clear previous protocol errors error in choose robot slideout #13487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serobotslideout Set a protocol-specific key in the ChooseProtocolSlideout instantiation from the ProtocolsList
ncdiehl11
requested review from
TamarZanzouri
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13487 +/- ##
=======================================================
- Coverage 71.23% 69.18% -2.05%
=======================================================
Files 1547 898 -649
Lines 50312 16964 -33348
Branches 3435 4776 +1341
=======================================================
- Hits 35838 11737 -24101
+ Misses 13945 3869 -10076
- Partials 529 1358 +829
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
pushed a commit
that referenced
this pull request
Sep 12, 2023
…serobotslideout (#13487) Set a protocol-specific key in the ChooseProtocolSlideout instantiation from the ProtocolsList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-1493
Overview
When attempting to start setup for a protocol that produces an analysis error from the ProtocolsLanding page, the selected device on the ChooseRobotSlideout displays a red error banner as expected. However, when the slideout is closed, and a new valid protocol is selected to run, the slideout still shows the error banner from the previous failed analysis. We need to ensure the slideout re-renders to clear the error banner for a new protocol selection.
Test Plan
Verify that an an error from a previous protocol attempt is cleared when a new protocol is selected:
https://github.com/Opentrons/opentrons/assets/47604184/d39064d3-9788-4deb-ad60-484bac7182f8
Verify that the same issue doesn't exist when choosing a protocol in the ChooseProtocolSlideout from RobotOverview
Changelog
Risk assessment
low