chore(api): go back to full blowout #13479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## configure-liquid-class-protocol-engine #13479 +/- ##
==========================================================================
+ Coverage 71.36% 71.38% +0.02%
==========================================================================
Files 2434 1586 -848
Lines 68174 52733 -15441
Branches 7961 3435 -4526
==========================================================================
- Hits 48652 37645 -11007
+ Misses 17659 14559 -3100
+ Partials 1863 529 -1334
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
force-pushed
the
configure-liquid-class-protocol-engine
branch
from
7971f28 to
60dfbea
Compare
sfoster1
force-pushed
the
back-to-full-blowout
branch
from
dbf2140 to
38c1b10
Compare
With the advent of push_out, we don't need a default blowout volume that isn't just "the full remaining length of the pipette" anymore - we can always default to moving to the end.
We added a default blowout volume to fix essentially the same issue that push_out fixes better. Now that we have push_out, let's go back to the full-length blowout as default (though we retain the ability to override it on command).
sfoster1
force-pushed
the
back-to-full-blowout
branch
from
38c1b10 to
cf39d10
Compare
sfoster1
added a commit
that referenced
this pull request
Sep 8, 2023
With the advent of push_out, we don't need a default blowout volume that isn't just "the full remaining length of the pipette" anymore - we can always default to moving to the end. We added a default blowout volume to fix essentially the same issue that push_out fixes better. Now that we have push_out, let's go back to the full-length blowout as default (though we retain the ability to override it on command).
sfoster1
added a commit
that referenced
this pull request
Sep 15, 2023
With the advent of push_out, we don't need a default blowout volume that isn't just "the full remaining length of the pipette" anymore - we can always default to moving to the end. We added a default blowout volume to fix essentially the same issue that push_out fixes better. Now that we have push_out, let's go back to the full-length blowout as default (though we retain the ability to override it on command).
sfoster1
added a commit
that referenced
this pull request
Sep 15, 2023
With the advent of push_out, we don't need a default blowout volume that isn't just "the full remaining length of the pipette" anymore - we can always default to moving to the end. We added a default blowout volume to fix essentially the same issue that push_out fixes better. Now that we have push_out, let's go back to the full-length blowout as default (though we retain the ability to override it on command).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a default blowout volume to fix essentially the same issue that
push_out fixes better. Now that we have push_out, let's go back to the
full-length blowout as default (though we retain the ability to override
it on command).
This removes the
defaultBlowoutVolumefrom the pipette configs and makes the code go back to doing a full-volume blowout, on the recommendation of hardware.